Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checker: set high priority for making up replicas #2972

Merged
merged 2 commits into from
Sep 16, 2020
Merged

checker: set high priority for making up replicas #2972

merged 2 commits into from
Sep 16, 2020

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Sep 16, 2020

What problem does this PR solve?

Making up replicas should be a high priority.

What is changed and how it works?

This PR sets the make-up-replica operator to high priority.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Set the make-up-replica operator to high priority

@rleungx
set high priority for making up replicas
7ab1fbd 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx added the component/checker Checker logic. label Sep 16, 2020
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 16, 2020
HunDunDM
HunDunDM approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 16, 2020
@nolouch
Copy link
Contributor

nolouch commented Sep 16, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 16, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 191e733 into tikv:master Sep 16, 2020
@rleungx rleungx added the needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. label Sep 17, 2020
ti-srebot pushed a commit to ti-srebot/pd that referenced this pull request Sep 17, 2020
@rleungx @ti-srebot
cherry pick tikv#2972 to release-4.0
5689d3e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 17, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #2977

rleungx added a commit to ti-srebot/pd that referenced this pull request Sep 17, 2020
@rleungx
cherry pick tikv#2972 to release-4.0
8513ade 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx added a commit to ti-srebot/pd that referenced this pull request Sep 21, 2020
@rleungx
cherry pick tikv#2972 to release-4.0
0e739ee 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
ti-srebot added a commit that referenced this pull request Sep 21, 2020
@ti-srebot
checker: set high priority for making up replicas (#2972) (#2977)
185d8c8 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti-srebot ti-srebot ti-srebot approved these changes

@HunDunDM HunDunDM HunDunDM approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@nolouch nolouch Awaiting requested review from nolouch

@disksing disksing Awaiting requested review from disksing

Assignees
No one assigned
Labels
component/checker Checker logic. needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rleungx @nolouch @ti-srebot @lhy1024 @HunDunDM